Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issue with workflow #6034

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

takameyer
Copy link
Contributor

What, How & Why?

This closes # ???

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

@takameyer takameyer force-pushed the andrew/fix-workflow-concurrency branch 3 times, most recently from edcb7c1 to 5940690 Compare August 8, 2023 07:49
@takameyer takameyer force-pushed the andrew/fix-workflow-concurrency branch from 5940690 to 453a360 Compare August 8, 2023 07:50
@takameyer
Copy link
Contributor Author

takameyer commented Aug 8, 2023

The strategy appears to be sound. Now any pushes to a branch will cancel the previously spawned actions, and pushes to other branches will not effect others. I have added this strategy to any pull_request based spawned action.

@takameyer takameyer merged commit eb91953 into main Aug 8, 2023
21 of 23 checks passed
@takameyer takameyer deleted the andrew/fix-workflow-concurrency branch August 8, 2023 08:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants